Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spass: fix darwin build #123509

Closed
wants to merge 1 commit into from
Closed

Conversation

stephank
Copy link
Contributor

Motivation for this change

ZHF: #122042
cc @NixOS/nixos-release-managers

Hydra failure: https://hydra.nixos.org/build/142946017/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 18, 2021
@stephank
Copy link
Contributor Author

stephank commented May 18, 2021

Oh, I didn't notice #37165. It apparently works with clang. What's the better solution?

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 18, 2021

Result of nixpkgs-review pr 123509 at 3ae4f82 run on aarch64-linux 1

1 package built successfully:
  • spass
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/applications/science/logic/spass/default.nix:24:3:

       |
    24 |   buildPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/science/logic/spass/default.nix:27:3:

       |
    27 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 123509 at 3ae4f82 run on x86_64-linux 1

2 packages built successfully:
  • spass
  • tests.trivial
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/science/logic/spass/default.nix:27:3:

       |
    27 |   installPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/applications/science/logic/spass/default.nix:24:3:

       |
    24 |   buildPhase = ''
       |   ^
    

@stephank
Copy link
Contributor Author

Closing this. It doesn't actually build without gccStdenv. Looks like it'd mostly just be some makefile changes that'd need to be upstreamed, but I don't see a way to contact upstream.

cc @mbode just in case you are interested in pursuing this, but I'm leaving it as is. 🙂

@stephank stephank closed this May 18, 2021
@stephank stephank deleted the fix-spass-darwin branch May 18, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants