goldendict: use ffmpeg instead of ffmpeg_3

[sikmir]

Motivation for this change

• use ffmpeg instead of ffmpeg_3 (migrate away from ffmpeg_3 #120705)
• changelog

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 123527 at 55c19deb run on x86_64-linux 1

2 packages built successfully:

• goldendict
• tests.trivial

2 suggestions:

• warning: missing-patch-comment

  Consider adding a comment explaining the purpose of this patch on the line preceeding.
  Near pkgs/applications/misc/goldendict/default.nix:23:5:

     |
  23 |     ./0001-dont-check-for-updates.patch
     |     ^
  

• warning: missing-patch-comment

  Consider adding a comment explaining the purpose of this patch on the line preceeding.
  Near pkgs/applications/misc/goldendict/default.nix:25:5:

     |
  25 |     ./0001-dont-use-maclibs.patch
     |     ^
  

[contrun]

Thanks. Goldendict built by nixpkgs-review pr 123527 works on my machine.

[bjornfor]

In order of preference:

1. Split out the version bump in a separate commit.
2. Say something about the version bump in the commit.

[sikmir]

In order of preference:

1. Split out the version bump in a separate commit.

2. Say something about the version bump in the commit.

Updated commit message.