Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlab: fix darwin build #123538

Merged
merged 1 commit into from May 19, 2021
Merged

texlab: fix darwin build #123538

merged 1 commit into from May 19, 2021

Conversation

yshym
Copy link
Contributor

@yshym yshym commented May 18, 2021

Motivation for this change

ZHF: #122042, @NixOS/nixos-release-managers
Hydra log: https://hydra.nixos.org/build/143298974/nixlog/3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 18, 2021
@ofborg ofborg bot requested review from kira-bruneau and doronbehar May 18, 2021 16:33
@kira-bruneau
Copy link
Contributor

Thanks for the fix! I'll approve this after the recommendations are applied.

jonringer
jonringer approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonringer jonringer merged commit e3f825b into NixOS:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephank stephank stephank left review comments

@kira-bruneau kira-bruneau kira-bruneau approved these changes

@jonringer jonringer jonringer approved these changes

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yshym @kira-bruneau @stephank @jonringer