[staging-next] glibc: restore version passthru #123548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
downstream packages use the major.minor version to determine ABI compatibility and paths which do not depend on patch version
jonringer
changed the title
|
cc @andir |
…evel" The fix is no longer required with the restored passthru version. This reverts commit 6020fe2.
|
@GrahamcOfBorg build elf-header |
|
Result of 1497 packages marked as broken and skipped:
35358 packages skipped due to time constraints:
312 packages built successfully:
Result of 1620 packages marked as broken and skipped:
30238 packages skipped due to time constraints:
258 packages built successfully:
|
|
@GrahamcOfBorg build elf-header-real |
|
able to build them locally |
|
This caused rebuild of Linux stdenvs. Was that itentional for staging-next at this point? |
|
Yeah, the staging cycles introduced a small regression with the glibc versions which are occasionally consumed by other derivations (and configure scripts). We could probably have held this off for one more cycle but IMHO we should fix things that break before merging the staging branch into master. |
|
OK, so I cancelled the builds obsoleted by this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
downstream packages use the major.minor version
to determine ABI compatibility and paths which
do not depend on patch version
related: #123279
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)