Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.clickhouse-driver: unbreak #123553

Merged
merged 1 commit into from May 19, 2021

Conversation

DavHau
Copy link
Member

@DavHau DavHau commented May 18, 2021

Motivation for this change

ZHF: #122042

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 18, 2021

Result of nixpkgs-review pr 123553 at af3505c run on x86_64-linux 1

3 packages built successfully:
  • python38Packages.clickhouse-driver
  • python39Packages.clickhouse-driver
  • tests.trivial

Result of nixpkgs-review pr 123553 at af3505c run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.clickhouse-driver
  • python39Packages.clickhouse-driver

@risicle
Copy link
Contributor

risicle commented May 18, 2021

Builds successfully, macos 10.15 & nixos x86_64

@risicle risicle merged commit 066fb63 into NixOS:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants