Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sunwait: fix darwin build #123560

Merged
merged 1 commit into from May 18, 2021
Merged

sunwait: fix darwin build #123560

merged 1 commit into from May 18, 2021

Conversation

stephank
Copy link
Contributor

Motivation for this change

ZHF: #122042
cc @NixOS/nixos-release-managers

Hydra failure: https://hydra.nixos.org/build/142959762/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 18, 2021
@jonringer
Copy link
Contributor

@GrahamcOfBorg build sunwait

@ofborg ofborg bot requested a review from etu May 18, 2021 18:13
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 18, 2021 •
edited

Result of nixpkgs-review pr 123560 at 755fa6d run on aarch64-linux 1

1 package built successfully:
  • sunwait
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/misc/sunwait/default.nix:16:3:

       |
16 |   installPhase = ''
   |   ^

Result of nixpkgs-review pr 123560 at 755fa6d run on x86_64-linux 1

2 packages built successfully:
  • sunwait
  • tests.trivial
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/misc/sunwait/default.nix:16:3:

       |
16 |   installPhase = ''
   |   ^

risicle
risicle approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM macos 10.15, nixos x86_64

@risicle risicle merged commit 82ffc8e into NixOS:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephank @jonringer @r-rmcgibbo @risicle