Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starspace: fix darwin build #123562

Merged
merged 1 commit into from May 18, 2021
Merged

Conversation

stephank
Copy link
Contributor

Motivation for this change

ZHF: #122042
cc @NixOS/nixos-release-managers

Hydra failure: https://hydra.nixos.org/build/142950592/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 18, 2021
@ofborg ofborg bot requested a review from mausch May 18, 2021 18:47
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123562 at 7c0c956 run on x86_64-linux 1

2 packages built successfully:
  • starspace
  • tests.trivial
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/science/machine-learning/starspace/default.nix:21:3:

       |
    21 |   installPhase = ''
       |   ^
    
  • warning: no-uri-literals

    URI literals are deprecated.
    Near pkgs/applications/science/machine-learning/starspace/default.nix:28:16:

       |
    28 |     homepage = https://ai.facebook.com/tools/starspace/;
       |                ^
    

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM macos 10.15 & nixos x86_64

@risicle risicle merged commit a3e5582 into NixOS:master May 18, 2021
@mausch
Copy link
Member

mausch commented May 18, 2021

I tested it on NixOS x86_64 too, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants