Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.geopandas: 0.8.1 → 0.9.0 #123637

Merged
merged 1 commit into from Jun 28, 2021
Merged

python3Packages.geopandas: 0.8.1 → 0.9.0 #123637

merged 1 commit into from Jun 28, 2021

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented May 19, 2021

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir sikmir requested a review from knedlsepp May 19, 2021 07:00
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 19, 2021 •
edited

Result of nixpkgs-review pr 123637 at c310a75 run on aarch64-linux 1

2 packages marked as broken and skipped:
  • python38Packages.osmnx
  • python39Packages.osmnx
2 packages failed to build:

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 123637 at c310a75 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python38Packages.osmnx
  • python39Packages.osmnx
3 packages built successfully:
  • python38Packages.geopandas
  • python39Packages.geopandas
  • tests.trivial

@sikmir
Copy link
Member Author

sikmir commented May 19, 2021 •
edited

Result of nixpkgs-review pr 123637 at c310a75 run on aarch64-linux 1
2 packages marked as broken and skipped:
2 packages failed to build:

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Looks like Fiona dependency is broken on aarch64-linux.

knedlsepp
knedlsepp approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@knedlsepp knedlsepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Looks good IMO.

@arkanoid87
Copy link
Contributor

not relevant, but I fixed the module on my machine in exactly the same way before looking for this existing pull request. So yeah, please remove descartes as it is a show stopper.

jonringer
jonringer approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 123637 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python38Packages.osmnx
  • python39Packages.osmnx
1 package blacklisted:
  • tests.trivial
2 packages built:
  • python38Packages.geopandas
  • python39Packages.geopandas

@jonringer jonringer merged commit e13f126 into NixOS:master Jun 28, 2021
@sikmir sikmir deleted the geopandas branch June 28, 2021 06:06
@pinselimo pinselimo mentioned this pull request Jun 30, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knedlsepp knedlsepp knedlsepp approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sikmir @r-rmcgibbo @arkanoid87 @knedlsepp @jonringer