New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make warning about authorizedKeys+NixOps more nuanced #123642
base: master
Are you sure you want to change the base?
Conversation
I marked this as stale due to inactivity. → More info |
What can I do to move this PR forward? |
I don't see any obvious evidence that NixOps would even behave this way. I've checked 1.7 and master, but neither seem to use something like Of course, me reading code doesn't prove much. This needs testing. |
@roberth would some manual testing suffice, or are you thinking of an automated test (maybe as part of this PR)? If the latter, could you maybe point me to some documentation about how testing is done in this project? |
@jleeuwes sorry for the late response. NixOps testing is split across the nixops repo and its providers; and it could use some improvement. Manual testing is sufficient for this change. |
This is a documentation-only change.
Motivation for this change
The warning about authorizedKeys in combination with NixOps is a bit too alarming. I'm using NixOps and provision my own keys, for which using authorizedKeys is just fine. Also, for non-root users there's also no problem.
Things done
Built the manual and visually checked that the change looked okay.