sanoid: 2.0.3 -> 2.1.0

[michaeladler]

Motivation for this change

This removes several cherry-picked (upstream) patches, so it reduces the maintenance cost of this package. Also, latest is greatest ;)

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions (Arch)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

@lopsided98 FYI since you are the maintainer

[r-rmcgibbo]

Result of nixpkgs-review pr 123644 at 4f365e7d run on x86_64-linux 1

2 packages built successfully:

• sanoid
• tests.trivial

3 suggestions:

• warning: unused-argument

  Unused argument: fetchpatch.
  Near pkgs/tools/backup/sanoid/default.nix:1:33:

    |
  1 | { lib, stdenv, fetchFromGitHub, fetchpatch, makeWrapper, zfs
    |                                 ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/tools/backup/sanoid/default.nix:20:3:

     |
  20 |   installPhase = ''
     |   ^
  

• warning: unclear-gpl

  gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

  Near pkgs/tools/backup/sanoid/default.nix:48:5:

     |
  48 |     license = licenses.gpl3;
     |     ^
  

[lopsided98]

Thanks for this PR! It's been on my todo list for a while. I will hopefully be able to test it over the weekend.

I have become frustrated with trying to get other sanoid related PRs (#83904, #98455, #104420) merged, but hopefully a simple update will be easier.

[SuperSandro2000]

diff LGTM. Ping me on matrix if I forget to merge it.

[lopsided98]

I deployed this to one of my systems yesterday and everything seems to be working correctly.

[lopsided98]

@SuperSandro2000 thanks for the reviews on the other sanoid PRs as well!