Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack: 4.15.0 -> 4.16.0 #123646

Merged
merged 1 commit into from May 23, 2021
Merged

slack: 4.15.0 -> 4.16.0 #123646

merged 1 commit into from May 23, 2021

Conversation

JesusMtnez
Copy link
Contributor

Motivation for this change

Update slack to 4.16.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123646 at f6dfcbc run on x86_64-linux 1

2 packages built successfully:
  • slack
  • tests.trivial
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/networking/instant-messengers/slack/default.nix:136:5:

        |
    136 |     installPhase = ''
        |     ^
    

@SuperSandro2000 SuperSandro2000 merged commit e6b0f03 into NixOS:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants