Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.karton-classifier: 1.0.0 -> 1.1.0 #123661

Merged
merged 1 commit into from May 19, 2021
Merged

pythonPackages.karton-classifier: 1.0.0 -> 1.1.0 #123661

merged 1 commit into from May 19, 2021

Conversation

chivay
Copy link
Member

@chivay chivay commented May 19, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fabaff May 19, 2021 10:57
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 19, 2021 •
edited

Result of nixpkgs-review pr 123661 at a13dd7d run on x86_64-linux 1

3 packages built successfully:
  • python38Packages.karton-classifier
  • python39Packages.karton-classifier
  • tests.trivial

Result of nixpkgs-review pr 123661 at a13dd7d run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.karton-classifier
  • python39Packages.karton-classifier

@fabaff
Copy link
Member

fabaff commented May 19, 2021

Result of nixpkgs-review pr 123661 run on x86_64-linux 1

3 packages built:
  • python38Packages.karton-classifier
  • python39Packages.karton-classifier
  • tests.trivial

fabaff
fabaff approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 0443320 into NixOS:master May 19, 2021
@chivay chivay deleted the bump-classifier branch May 19, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chivay @r-rmcgibbo @fabaff