haskell.packages: deal with evaluation fall out of most recent stackage update #123683
Conversation
random 1.2.0 has a new test suite with a lot of dependencies. Among other packages it depends on doctest which depends on syb which depends on tasty which depends on optparse-applicative which depends on QuickCheck which depends on -- you guessed it -- random! The cycle could be broken at any point of course, I've disabled the tests on random here because it has seen the change that causes all of this. However, we may also want to consider doing this for optparse-applicative instead, since random seems like a more critical package to run the tests for possibly? Not sure, looking for feedback.
|
Eval error is on target branch, so check meaningless. |
|
I feel like I had encountered these issues before. Can you tell how the loop got introduced? |
We arrived at 0.14.0.0 naturally via stackage.
hashable's test suite pins random to < 1.2 even in the latest release on hackage, but lifting the bound fixes the build without any issues. Using a patch so we are reminded to remove it when it's unnecessary.
These are not necessary anymore as stackage naturally contains random 1.2.0 and we apply the hashable fix globally as well.
random 1.2.0 is our default version now.
sternenseemann
changed the title
As outlined in the commit message: random 1.2.0 tests -> doctest -> syb tests -> tasty -> optparse-applicative tests -> QuickCheck -> random 1.2.0 We actually had that in |
|
Great, this looks like it gets everything evaluating again with |
What I meant is: Is this a new problem or did older random versions also have this loop and how did we solve this then? But it’s not that important … |
|
This is a new problem due to the update to random 1.2.0. Previously randoms test suite only depended on base. |
random 1.2.0 has a new test suite with a lot of dependencies. Among
other packages it depends on doctest which depends on syb which depends
on tasty which depends on optparse-applicative which depends on
QuickCheck which depends on -- you guessed it -- random!
The cycle could be broken at any point of course, I've disabled the
tests on random here because it has seen the change that causes all
of this. However, we may also want to consider doing this for
optparse-applicative instead, since random seems like a more critical
package to run the tests for possibly? Not sure, looking for feedback.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)