Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bunyan-rs: init at 0.1.2 #123684

Merged
merged 1 commit into from May 23, 2021
Merged

bunyan-rs: init at 0.1.2 #123684

merged 1 commit into from May 23, 2021

Conversation

netcrns
Copy link
Contributor

@netcrns netcrns commented May 19, 2021 •
edited

Motivation for this change

It's just a nice piece of software to have handy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@legendofmiracles
Copy link
Contributor

Result of nixpkgs-review pr 123684 run on x86_64-linux 1

1 package failed to build:
  • tests.trivial

@netcrns
Copy link
Contributor Author

netcrns commented May 19, 2021

Result of nixpkgs-review pr 123684 run on x86_64-linux 1
1 package failed to build:

Odd, it works perfectly fine on my machine.

@netcrns
Copy link
Contributor Author

netcrns commented May 19, 2021

Result of nixpkgs-review pr 123684 run on x86_64-linux 1

1 package built:
  • tests.trivial

@netcrns netcrns force-pushed the netcrns/bunyan branch 2 times, most recently from bcf3c25 to d130881 Compare May 20, 2021 20:32
@netcrns
Copy link
Contributor Author

netcrns commented May 20, 2021

Silly me forgot to add bunyan-rs to all-packages.nix... 😅

@legendofmiracles
Copy link
Contributor

Result of nixpkgs-review pr 123684 run on x86_64-linux 1

1 package built:
  • bunyan-rs

@legendofmiracles
Copy link
Contributor

Squash all package related commits

@netcrns
bunyan-rs: init at 0.1.2
119a3e6 
Update pkgs/development/tools/bunyan-rs/default.nix
@SuperSandro2000 SuperSandro2000 merged commit ad4b24a into NixOS:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@legendofmiracles legendofmiracles legendofmiracles approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@netcrns @legendofmiracles @SuperSandro2000