New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark wayland broken on Darwin/Big Sur #123686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To comply with CONTRIBUTING.md please have the commit message name be of the format
<pkg-name>: <subject-line>
for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes
in your case, the commit message should be:
wayland: mark broken for darwin
also, in the commit message, can you add some details. The code comment should suffice :)
Do you mind squashing the two commits? Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks @edude03
Thanks @jonringer - although I do know how to rebase, I still really appreciate you linking to resources in case I didn't. I think it's really welcoming to new members of the community |
I had someone ask once, so just made a saved reply explaining it :) |
Does this still apply? I was able to compile wayland without issue.
|
Motivation for this change
ZHF: #122042, ping @NixOS/nixos-release-managers
As mentioned in the comment, it seems like in the work @thefloweringash & co did to get nixpkgs working on Big Sur means that apps that need GCC to build no longer work (like Wayland). Maybe there is a way to bring support back, but at least for now it's broken.
On a side note, is there a way to check if stdenv is using clang or gcc? maybe a better check would be to check for clang instead.
Also, it does seem like GCC does work on big sur now https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97865 so maybe we can fix this.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)