Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pantheon.elementary-calculator: 1.6.0 -> 1.6.1 #123691

Merged
merged 1 commit into from May 19, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for pantheon.elementary-calculator is: "Calculator app designed for elementary OS"

meta.homepage for pantheon.elementary-calculator is: "https://github.com/elementary/calculator"

meta.changelog for pantheon.elementary-calculator is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/20hhpq6y4h3qsx11kmn322a48f0hyz0q-elementary-calculator-1.6.1/bin/io.elementary.calculator passed the binary check.

  • /nix/store/20hhpq6y4h3qsx11kmn322a48f0hyz0q-elementary-calculator-1.6.1/bin/.io.elementary.calculator-wrapped passed the binary check.

  • 2 of 2 passed binary check by having a zero exit code.

  • 0 of 2 passed binary check by having the new version present in output.

  • found 1.6.1 with grep in /nix/store/20hhpq6y4h3qsx11kmn322a48f0hyz0q-elementary-calculator-1.6.1

  • found 1.6.1 in filename of file in /nix/store/20hhpq6y4h3qsx11kmn322a48f0hyz0q-elementary-calculator-1.6.1

  • directory tree listing: https://gist.github.com/d7745a0c6f7d0792dcddb39b644e8636

  • du listing: https://gist.github.com/c7902607d8124ddb596fef79a85ef752


Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
pantheon.elementary-calculator
tests.trivial
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/20hhpq6y4h3qsx11kmn322a48f0hyz0q-elementary-calculator-1.6.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A pantheon.elementary-calculator https://github.com/r-ryantm/nixpkgs/archive/dd55fbe473a7f270ad3a0939abdd68a021380af5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/20hhpq6y4h3qsx11kmn322a48f0hyz0q-elementary-calculator-1.6.1
ls -la /nix/store/20hhpq6y4h3qsx11kmn322a48f0hyz0q-elementary-calculator-1.6.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • pantheon.elementary-calculator

Maintainer pings

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 19, 2021

Result of nixpkgs-review pr 123691 at dd55fbe run on x86_64-linux 1

2 packages built successfully:
  • pantheon.elementary-calculator
  • tests.trivial
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/desktops/pantheon/apps/elementary-calculator/default.nix:68:5:

       |
    68 |     maintainers = pantheon.maintainers;
       |     ^
    

Result of nixpkgs-review pr 123691 at dd55fbe run on aarch64-linux 1

1 package built successfully:
  • pantheon.elementary-calculator

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/123691

2 packages built:
pantheon.elementary-calculator tests.trivial

@jonringer jonringer merged commit 457e319 into NixOS:master May 19, 2021
@r-ryantm r-ryantm deleted the auto-update/elementary-calculator branch May 20, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants