Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc: make darwin friendly #123702

Merged
merged 1 commit into from May 19, 2021
Merged

solc: make darwin friendly #123702

merged 1 commit into from May 19, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented May 19, 2021

Motivation for this change

Address #115034 (comment)

cc @hlolli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@hlolli hlolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using solc for the first time.

But it compiles, and when testing hello world

(on nixos-darwin, M1 macbook pro)

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;
contract helloWorld {
 function renderHelloWorld () public pure returns (string memory) {
   return 'helloWorld';
 }
}
[nix-shell:~/.cache/nixpkgs-review/pr-123702]$ solc --bin -o solcoutput solc_text.sol
Compiler run successful. Artifact(s) can be found in directory solcoutput.

@jonringer
Copy link
Contributor Author

darwin failure is from tests. Probably would need additional work to get tests to work (they are disabled by default, only passthru.tests runs them).

@jonringer jonringer merged commit 274a71f into NixOS:master May 19, 2021
@jonringer jonringer deleted the solc-darwin branch May 19, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants