tiramisu: 1.0 -> unstable-2021-05-20

[moni-dz]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 123703 at b3322e6 run on x86_64-linux 1

2 packages built successfully:

• tests.trivial
• tiramisu

---

Result of nixpkgs-review pr 123703 at b3322e6 run on aarch64-linux 1

1 package built successfully:

• tiramisu

[wishfort36]

Result of nixpkgs-review pr 123703 1

2 packages built:

• tests.trivial
• tiramisu

[wishfort36]

The diff itself LGTM. Now that two more commits have been added, you might want to consider adding those as well. I built the package manually as well, which compiled. During testing, I managed to find a really weird bug where when running

$ while :; do notify-send -a $STR "hi"; done

where the app name, $STR, is a string of lengths 2, 5, 7, 13, 18, 20, 22, or 29 (tested up to 30), on commits after 8eb946d (that is, after a425e43 as I couldn't get that one to compile), causes a segfault. This bug was reproduced on two NixOS machines, and on an Arch one as well.

I'm not sure what to do from hereon, but I think this is a good enough reason to block the PR for now. While it's an obscure bug, I still managed to coincidentally trigger it while testing. This should mean that others might be able to coincidentally trigger it as well. I'll open a issue upstream, and we'll see what happens.

[moni-dz]

Should be good to merge, since the bug was fixed upstream.