Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cryptography: add missing libiconv build dependency on darwin #123706

Merged
merged 1 commit into from May 19, 2021
Merged

python3Packages.cryptography: add missing libiconv build dependency on darwin #123706

merged 1 commit into from May 19, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented May 19, 2021

Motivation for this change

Fixing the following:

error: linking with `/nix/store/l3ca456ppdy8hi9hc0rvyr6mrm76si08-clang-wrapper-11.1.0/bin/cc` failed: exit code: 1
  = note: ld: library not found for -liconv
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobrik
python3Packages.cryptography: add missing libiconv build dependency o…
77fa99e 
…n darwin

Fixing the following:

```
error: linking with `/nix/store/l3ca456ppdy8hi9hc0rvyr6mrm76si08-clang-wrapper-11.1.0/bin/cc` failed: exit code: 1
  = note: ld: library not found for -liconv
```
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 19, 2021
@bobrik bobrik mentioned this pull request May 19, 2021
Merged
@ofborg ofborg bot requested a review from primeos May 19, 2021 17:26
@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.cryptography

primeos
primeos approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI build for Darwin did unfortunately timeout (https://github.com/NixOS/nixpkgs/pull/123706/checks?check_run_id=2623171370) but this LGTM.

@jonringer jonringer merged commit 703579f into NixOS:staging-next May 19, 2021
@bobrik bobrik deleted the ivan/cryptography-iconv branch May 20, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobrik @jonringer @primeos