Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netdata: Enable cloud support using ACLK-NG #123709

Merged
merged 4 commits into from May 28, 2021

Conversation

leotaku
Copy link
Contributor

@leotaku leotaku commented May 19, 2021

Motivation for this change

This PR enables Netdata cloud support using ACLK-NG if not on MacOS/Darwin for the Netdata package. This PR is based on #123707, which contains only the update of Netdata to version 1.31.0.

Would close #91549

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 19, 2021

Result of nixpkgs-review pr 123709 at 717a372c run on x86_64-linux 1

2 packages built successfully:
  • netdata
  • tests.trivial
2 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/tools/system/netdata/default.nix:90:5:

       |
    90 |     maintainers = [ ];
       |     ^
    
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/tools/system/netdata/default.nix:11:3:

       |
    11 | , fetchpatch
       |   ^
    

Result of nixpkgs-review pr 123709 at ae0c269 run on aarch64-linux 1

1 package built successfully:
  • netdata

@leotaku
Copy link
Contributor Author

leotaku commented May 21, 2021

I have just learned that ACLK-NG, the mechanism we would like to use to enable cloud support is currently broken on MacOS/Darwin (See netdata/netdata#10842). I will edit this PR to conditionally disable the agent-cloud link if we are on Darwin.

@leotaku leotaku marked this pull request as draft May 21, 2021 17:04
@leotaku leotaku marked this pull request as ready for review May 21, 2021 21:48
@K900
Copy link
Contributor

K900 commented May 28, 2021

Anything blocking this? I've been running it locally for a bit and it seems to work well.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 123709 run on x86_64-linux 1

1 package built:
  • netdata

@RaghavSood RaghavSood merged commit 491a0bb into NixOS:master May 28, 2021
@wmertens
Copy link
Contributor

I'd like to see this backported to 21.05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netdata: cloud streaming support
5 participants