New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uade: init at 2.13 #123723

Closed

svanderburg wants to merge 1 commit into NixOS:master from svanderburg:add-uade

Member

svanderburg commented May 19, 2021 •

edited

Motivation for this change

Things done


          uade: init at 2.13

8a86b7c

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels

r-rmcgibbo commented May 19, 2021

Result of nixpkgs-review pr 123723 at 8a86b7c run on x86_64-linux 1

2 packages built successfully:

tests.trivial
uade

3 suggestions:

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/audio/uade/default.nix:24:5:
```
   |
24 |     license = licenses.gpl2;
   |     ^
```
warning: build-tools-in-build-inputs
which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/applications/audio/uade/default.nix:10:3:
```
   |
10 |   buildInputs = [ pkg-config which libao ];
   |   ^
```
warning: build-tools-in-build-inputs
pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/applications/audio/uade/default.nix:10:3:
```
   |
10 |   buildInputs = [ pkg-config which libao ];
   |   ^
```

svanderburg closed this

Member Author

svanderburg commented May 19, 2021

Hmm I just noticed, we had already packaged uade123. I was confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment