Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsl: cap MACOSX_DEPLOYMENT_TARGET at 10.16 #123729

Merged
merged 1 commit into from May 20, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented May 19, 2021

Motivation for this change

It blocks 38 packages on aarch64-darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 19, 2021
@bobrik bobrik mentioned this pull request May 19, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 19, 2021

Result of nixpkgs-review pr 123729 at 74acf463 run on x86_64-linux 1

13 packages marked as broken and skipped:
  • gnome.gnome-documents
  • gnuradio3_7
  • gnuradio3_7Packages.ais
  • gnuradio3_7Packages.gnuradio
  • gnuradio3_7Packages.gsm
  • gnuradio3_7Packages.limesdr
  • gnuradio3_7Packages.nacl
  • gnuradio3_7Packages.osmosdr
  • gnuradio3_7Packages.rds
  • k2pdfopt
  • ...
133 packages skipped due to time constraints:
  • ViennaRNA (python38Packages.ViennaRNA ,python39Packages.ViennaRNA)
  • adapta-gtk-theme
  • arc-theme
  • arx-libertatis
  • asciidoc-full
  • asciidoc-full-with-plugins
  • bibata-cursors
  • bibata-cursors-translucent
  • bibata-extra-cursors
  • btrbk
  • ...
4 packages built successfully:
  • est-sfs
  • gsl
  • python38Packages.cvxopt
  • python39Packages.cvxopt
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/gsl/default.nix:21:3:

       |
    21 |   meta = {
       |   ^
    

Result of nixpkgs-review pr 123729 at b4d5355f run on aarch64-linux 1

15 packages marked as broken and skipped:
  • gnome.gnome-documents
  • gnuradio3_7
  • gnuradio3_7Packages.ais
  • gnuradio3_7Packages.gnuradio
  • gnuradio3_7Packages.gsm
  • gnuradio3_7Packages.limesdr
  • gnuradio3_7Packages.nacl
  • gnuradio3_7Packages.osmosdr
  • gnuradio3_7Packages.rds
  • herwig
  • ...
6 packages failed to build:
90 packages skipped due to time constraints:
  • adapta-gtk-theme
  • arc-theme
  • arx-libertatis
  • asciidoc-full
  • asciidoc-full-with-plugins
  • bibata-cursors
  • bibata-cursors-translucent
  • bibata-extra-cursors
  • btrbk
  • calligra
  • ...
23 packages built successfully:
  • ViennaRNA (python38Packages.ViennaRNA ,python39Packages.ViennaRNA)
  • clight
  • enblend-enfuse
  • est-sfs
  • gjay
  • gsl
  • guvcview
  • indi-full
  • indilib
  • ipe
  • nip2
  • orpie
  • pfstools
  • python38Packages.cvxopt
  • python38Packages.cvxpy
  • python38Packages.osqp
  • python38Packages.picos
  • python39Packages.cvxopt
  • python39Packages.cvxpy
  • python39Packages.osqp
  • python39Packages.picos
  • snd
  • stellarsolver
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/gsl/default.nix:21:3:

       |
    21 |   meta = {
       |   ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 123729 run on x86_64-linux 1

1 package built:
  • tests.trivial

@jonringer jonringer merged commit 274ec21 into NixOS:staging-next May 20, 2021
@bobrik bobrik deleted the ivan/aarch64-gsl branch May 20, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants