ruby: improve reproducibility of gem builds #123732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
changed the title
baloo
force-pushed
the
baloo/rubygem/reproducible
branch
from
23feea1
to
e5dfdd1
Compare
baloo
changed the title
|
Great, I did a checkout and nokogiri + racc are now reproducible! I just looked at that folder and it's indeed empty (at least for nokogiri), so no harm in deleting it. LGTM, regex should indeed only match that folder. |
github-actions
bot
added
6.topic: nixos
6.topic: pantheon
By default, the gem build will leave a path like: lib/ruby/gems/2.7.0/gems/racc-1.5.2/ext/racc/cparse/.gem.20210503-6-csuqdb putting the build date in the output hurts the build reproducibility efforts see NixOS#123718 Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
baloo
force-pushed
the
baloo/rubygem/reproducible
branch
from
e5dfdd1
to
44d9769
Compare
github-actions
bot
removed
6.topic: qt/kde
8.has: module (update)
6.topic: pantheon
|
it's an upstream logic bug in rubygems. |
|
closed in favor of #123748 |
|
Taking it upstream is indeed nicer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
By default, the gem build will leave a path like:
lib/ruby/gems/2.7.0/gems/racc-1.5.2/ext/racc/cparse/.gem.20210503-6-csuqdb
putting the build date in the output hurts the build reproducibility
efforts
see #123718
This is the tmp directory here https://github.com/ruby/ruby/blob/adcbae8d49ec04d365ce13274783b1495c3c7d0e/lib/rubygems/ext/ext_conf_builder.rb#L15
https://github.com/ruby/ruby/blob/adcbae8d49ec04d365ce13274783b1495c3c7d0e/lib/tmpdir.rb#L140
that is not collected correctly.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)