Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nwjs: use ffmpeg instead of ffmpeg_3 #123796

Merged
merged 1 commit into from May 20, 2021
Merged

nwjs: use ffmpeg instead of ffmpeg_3 #123796

merged 1 commit into from May 20, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

#120705

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda mentioned this pull request May 20, 2021
Closed
@ofborg ofborg bot requested a review from offlinehacker May 20, 2021 11:56
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123796 at 27872b0 run on x86_64-linux 1

3 packages built successfully:
  • betaflight-configurator
  • nwjs
  • nwjs-sdk
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/tools/nwjs/default.nix:55:3:

       |
55 |   installPhase =
   |   ^

jonringer
jonringer approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 123796 run on x86_64-linux 1

3 packages built:
  • betaflight-configurator
  • nwjs
  • nwjs-sdk

@jonringer jonringer merged commit 2680cfc into NixOS:master May 20, 2021
@dotlambda dotlambda deleted the nwjs-ffmpeg branch May 20, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @r-rmcgibbo @jonringer