microsoft-edge-beta: init at 91.0.864.27 #123805
Conversation
|
Result of 1 package built successfully:
2 suggestions:
|
| test -e $out/share/microsoft/$appname/libEGL.so | ||
| ln -s libEGL.so $out/share/microsoft/$appname/libEGL.so.1 | ||
| test -e $out/share/microsoft/$appname/libGLESv2.so | ||
| ln -s libGLESv2.so $out/share/microsoft/$appname/libGLESv2.so.2 |
There was a problem hiding this comment.
are the test commands necessary anymore?
| @@ -16846,6 +16846,8 @@ in | |||
|
|
|||
| microsoft_gsl = callPackage ../development/libraries/microsoft_gsl { }; | |||
|
|
|||
| microsoft-edge-beta = callPackage ../applications/networking/browsers/microsoft-edge { gconf = gnome2.GConf; }; | |||
There was a problem hiding this comment.
cc @NixOS/gnome is there a better alternative to using something from gnome2?
There was a problem hiding this comment.
GConf should not be used at all these days, it has been deprecated for almost ten years.
There was a problem hiding this comment.
Both chromium and google-chrome have this dependency. It seems like upstream dropped GConf in favor of gsettings in 2017, though.
There was a problem hiding this comment.
Yeah, almost nothing uses it these days. I started cleaning it up (#39976) but there are still many instances.
|
I based this heavily on the Google Chrome package. They're unsurprisingly
very similar, I'd be surprised if anything was necessary on one but not the
other.
…On Thu, May 20, 2021, 3:05 PM Jonathan Ringer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/applications/networking/browsers/microsoft-edge/default.nix
<#123805 (comment)>:
> + test -e $out/share/microsoft/$appname/libEGL.so
+ ln -s libEGL.so $out/share/microsoft/$appname/libEGL.so.1
+ test -e $out/share/microsoft/$appname/libGLESv2.so
+ ln -s libGLESv2.so $out/share/microsoft/$appname/libGLESv2.so.2
are the test commands necessary anymore?
------------------------------
In pkgs/top-level/all-packages.nix
<#123805 (comment)>:
> @@ -16846,6 +16846,8 @@ in
microsoft_gsl = callPackage ../development/libraries/microsoft_gsl { };
+ microsoft-edge-beta = callPackage ../applications/networking/browsers/microsoft-edge { gconf = gnome2.GConf; };
cc @NixOS/gnome <https://github.com/orgs/NixOS/teams/gnome> is there a
better alternative to using something from gnome2?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#123805 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7X32P663HRG4HXLESQAD3TOVMOLANCNFSM45HBTZQQ>
.
|
That's because Edge is based on Chromium. |
| libxkbcommon wayland | ||
| ] ++ optional pulseSupport libpulseaudio | ||
| ++ optional libvaSupport libva | ||
| ++ optional vulkanSupport vulkan-loader | ||
| ++ [ gtk3 ]; |
There was a problem hiding this comment.
| libxkbcommon wayland | |
| ] ++ optional pulseSupport libpulseaudio | |
| ++ optional libvaSupport libva | |
| ++ optional vulkanSupport vulkan-loader | |
| ++ [ gtk3 ]; | |
| libxkbcommon wayland gtk3 | |
| ] ++ optional pulseSupport libpulseaudio | |
| ++ optional libvaSupport libva | |
| ++ optional vulkanSupport vulkan-loader; |
There was a problem hiding this comment.
Should this change also be applied to Chrome?
There was a problem hiding this comment.
It would be nice. It might be even better to format the Chrome expression with nixpkgs-fmt, then do these cleanups and then fork it to edge.
|
? |
|
I tested |
|
I also testes! LGTM. I think there're only some formatting issues |
Motivation for this change
Microsoft Edge is an increasingly popular web browser. Even if people don't use it themselves, developers on NixOS may wish to be able to test pages and extensions in it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)