Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytmdesktop: init at 1.13.0 #123829

Merged
merged 2 commits into from May 22, 2021
Merged

Conversation

LogicalOverflow
Copy link
Contributor

Motivation for this change

Adds https://ytmdesktop.app/, a desktop app for YouTube Music, closes #122725.

I've been using this package locally for a few days, and so far everything seems to be working fine. I tried running it with strace -vfefile and did not find any missing libraries.

As this packages just wraps the AppImage, it does not support MacOS, even thought the application itself does. I tried building it from source at first, but sadly couldn't get that to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add an entry to pkgs/top-level/all-packages.nix for this to be discoverable:

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/123829

$ nix-shell /home/jon/.cache/nixpkgs-review/pr-123829/shell.nix

@LogicalOverflow
Copy link
Contributor Author

Thanks. I added that now.

@SuperSandro2000 SuperSandro2000 merged commit f1452b8 into NixOS:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Youtube Music Desktop
3 participants