Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bracey #123946

Merged
merged 2 commits into from May 22, 2021
Merged

Bracey #123946

merged 2 commits into from May 22, 2021

Conversation

notusknot
Copy link
Contributor

Simply adding the bracey.vim plugin to the repository

@notusknot notusknot requested a review from jonringer as a code owner May 22, 2021 00:16
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123946 at cad5b1d run on x86_64-linux 1

8 packages built successfully:
  • spacevim
  • vimPlugins.bracey-vim
  • vimPlugins.chadtree
  • vimPlugins.hologram-nvim
  • vimPlugins.mkdx
  • vimPlugins.nnn-vim
  • vimPlugins.nvim-lspconfig
  • vimPlugins.vim-oscyank
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^

@jonringer
Copy link
Contributor

@notusknot congrats on your first contribution to nixpkgs :)

jonringer
jonringer approved these changes May 22, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 123946 run on x86_64-linux 1

8 packages built:
  • spacevim
  • vimPlugins.bracey-vim
  • vimPlugins.chadtree
  • vimPlugins.hologram-nvim
  • vimPlugins.mkdx
  • vimPlugins.nnn-vim
  • vimPlugins.nvim-lspconfig
  • vimPlugins.vim-oscyank

@jonringer jonringer merged commit 1c4571c into NixOS:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@notusknot @r-rmcgibbo @jonringer @Janik-Haag