Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: octave_kernel at 0.32.0, metakernel at 0.27.5 #123948

Merged
merged 2 commits into from Jun 21, 2021

Conversation

thomasjm
Copy link
Contributor

Motivation for this change

Init the Octave Jupyter kernel. Needed to add the Python metakernel package as a dependency as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu 20.04)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@thomasjm thomasjm requested a review from jonringer May 22, 2021 08:40
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fetch the image files from a remote.

Also please format the new files with nixpkgs-fmt.

pkgs/development/python-modules/metakernel/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/metakernel/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/metakernel/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

sorry if my latest comments are out of date, looks like I forgot to submit last night

@ethancedwards8
Copy link
Member

Result of nixpkgs-review pr 123948 run on x86_64-darwin 1

2 packages built:
  • python38Packages.metakernel
  • python39Packages.metakernel

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please put each package into one init commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants