Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/boot: test on aarch64 #124415

Merged
merged 4 commits into from
Jul 14, 2021
Merged

nixos/boot: test on aarch64 #124415

merged 4 commits into from
Jul 14, 2021

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented May 25, 2021

Motivation for this change

Add aarch64 support for nixosTests.boot.uefiCdrom nixosTests.boot.uefiUsb and nixosTests.boot.uefiNetboot.

Related: #106304

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@misuzu
Copy link
Contributor Author

misuzu commented May 25, 2021

@GrahamcOfBorg test boot.biosCdrom boot.biosUsb boot.biosNetboot boot.uefiCdrom boot.uefiUsb boot.uefiNetboot

@misuzu misuzu marked this pull request as ready for review May 25, 2021 19:55
@misuzu misuzu requested a review from tfc as a code owner May 25, 2021 19:55
@misuzu misuzu requested a review from samueldr May 25, 2021 19:55
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 25, 2021

Result of nixpkgs-review pr 124415 at a65ee14c run on aarch64-linux 1

1 package built successfully:
  • ipxe
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/misc/ipxe/default.nix:74:3:

       |
    74 |   installPhase = ''
       |   ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/tools/misc/ipxe/default.nix:91:7:

       |
    91 |       license = licenses.gpl2;
       |       ^
    

Result of nixpkgs-review pr 124415 at a65ee14c run on x86_64-linux 1

2 packages built successfully:
  • ipxe
  • tests.trivial
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/misc/ipxe/default.nix:74:3:

       |
    74 |   installPhase = ''
       |   ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/tools/misc/ipxe/default.nix:91:7:

       |
    91 |       license = licenses.gpl2;
       |       ^
    

@misuzu
Copy link
Contributor Author

misuzu commented Jul 14, 2021

@GrahamcOfBorg test boot.biosCdrom boot.biosUsb boot.biosNetboot boot.uefiCdrom boot.uefiUsb boot.uefiNetboot

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/561

@symphorien symphorien merged commit 5a4320c into NixOS:master Jul 14, 2021
@misuzu
Copy link
Contributor Author

misuzu commented Jul 14, 2021

Thanks, @symphorien!

@misuzu misuzu deleted the aarch64-boot-test branch June 7, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants