Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/apparmor: allow closure of selected mallocLib, fixes #125415 #125966

Merged
merged 1 commit into from Sep 21, 2021

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Jun 6, 2021

Motivation for this change

Supporting environment.memoryAllocator.provider != libc by allowing all programs including the abstractions/base AppArmor profile to load the dependencies of the selected malloc library (and not only the library itself).
See #125415

Things done
  • Add apparmorRulesFromClosure on mallocLib to the abstractions/base AppArmor profile.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ju1m ju1m changed the title nixos/apparmor: allow closure of custom mallocLib, fixes #125415 nixos/apparmor: allow closure of selected mallocLib, fixes #125415 Jun 6, 2021
@Izorkin
Copy link
Contributor

Izorkin commented Jun 6, 2021

Thanks, working!

@ju1m
Copy link
Contributor Author

ju1m commented Jul 23, 2021

@SuperSandro2000 just a ping to be sure this fix is on your radar. It's ready to merge.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/400

@aanderse
Copy link
Member

Sorry @SuperSandro2000 I'm not familiar with apparmor enough to review this.

@SuperSandro2000 SuperSandro2000 removed the request for review from aanderse September 21, 2021 20:07
@SuperSandro2000 SuperSandro2000 merged commit bfc38d3 into NixOS:master Sep 21, 2021
@ju1m ju1m deleted the apparmor branch December 29, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants