.github/workflows/rebase.yml: remove

[zowoq]

It's kinda broken half the time and I've given up on trying to fix it as I can't get a response in #124560 so it's better if we just remove it entirely.

[Mic92]

It worked better for me than my manual attempts of rebasing...

[Mic92]

Just removing the action because you did not get a response, does not seem like a good course of action.

[zowoq]

Just removing the action because you did not get a response, does not seem like a good course of action.

If I can't even get a response in a reasonable time how long is going to take to actually get the token added and the PR merged?

[zowoq]

So this actually hasn't been working for two weeks, it has been triggered ~25 times and failed every time.

I'm not going to spend any time fixing the current implementation considering I've been trying to push the rewrite forward.

Removing it seems like the best option.

[domenkozar]

Is there something preventing us to use an existing action like https://github.com/cirrus-actions/rebase

[github-actions]

Failed to rebase

[zowoq]

Is there something preventing us to use an existing action like

Yes, it doesn't rebase across branches.

[domenkozar]

Is there something preventing us to use an existing action like

Yes, it doesn't rebase across branches.

Could you explain that workflow, I'm not sure what you're referring to.

[zowoq]

Rebasing from master to {staging,staging-next,whatever}. The action you linked will only rebase on the same branch, e.g. master on master.

[zowoq]

Even if we used another action it would still really need another token as the default token doesn't trigger PR actions which is why the current rebase command is using a close/reopen workaround.

[domenkozar]

Rebasing from master to {staging,staging-next,whatever}. The action you linked will only rebase on the same branch, e.g. master on master.

Isn't that handled by changing the base branch? I wonder if it's really possible to do automatically if two branches diverge.

[zowoq]

nixpkgs/.github/workflows/rebase.yml

Lines 6 to 7 in 8329c0d

	# This action allows people with write access to the repo to rebase a PRs base branch
	# by commenting `/rebase ${branch}` on the PR while avoiding CODEOWNER notifications.

[github-actions]

Failed to rebase

[domenkozar]

@zowoq If no such action exists yet, I'd really encourage to write on outside of nixpkgs and then we can just use it here?

[zowoq]

If no such action exists yet, I'd really encourage to write on outside of nixpkgs and then we can just use it here?

I don't see that it would be useful anywhere else except in this repo. I also don't want to maintain an external repo for ~120 loc. If it didn't need to be in .github/workflows to be useable as an action it would be in maintainers/scripts.

@domenkozar Are you going to address my initial comment in (#124560 (comment)) asking about adding a non-default token?

If I can't get an affirmative response about that there really isn't anything else to discuss here.