Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpsoffice: fix crash #126302

Merged
merged 1 commit into from Oct 9, 2021
Merged

wpsoffice: fix crash #126302

merged 1 commit into from Oct 9, 2021

Conversation

Ninlives
Copy link
Contributor

@Ninlives Ninlives commented Jun 9, 2021

Motivation for this change

Fixes #125951
Use steam-run to create a fhs and launch the application to avoid possible issues, note that the closure is not minimized.

Cc @Th0rgal

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/541

Copy link
Member

@bobby285271 bobby285271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, as a user of this, I can confirm it works. Can you resolve the merge conflict?

As this is staled for too long and debugging with this package is hard, I will merge this as soon as ofborg eval passes, further improvements and version updates can be made by new pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkgs.wpsoffice] crash with no logs, but works on steam-run
3 participants