Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mautrix-whatsapp: 0.1.6 -> unstable-2021-06-15 #126966

Merged
merged 1 commit into from Jun 15, 2021
Merged

mautrix-whatsapp: 0.1.6 -> unstable-2021-06-15 #126966

merged 1 commit into from Jun 15, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 15, 2021 •
edited

Motivation for this change

On master there are a few more bugfixes. Most notably, each message
sent by me was marked as "not sent" by WhatsApp for the last four days
until you hit a "Resend" in WhatsApp.

As the update to the latest master has solved the issue and being able
to correctly send messages is one of the core features of this package,
I decided to update the package in nixpkgs as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Ma27
mautrix-whatsapp: 0.1.6 -> unstable-2021-06-15
5c7156f 
On `master` there are a few more bugfixes. Most notably, each message
sent by me was marked as "not sent" by WhatsApp for the last four days
until you hit a "Resend" in WhatsApp.

As the update to the latest `master` has solved the issue and being able
to correctly send messages is one of the core features of this package,
I decided to update the package in `nixpkgs` as well.
@ofborg ofborg bot requested review from kalbasit and Vskilet June 15, 2021 16:17
sbruder
sbruder approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@sbruder sbruder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This works for me and fixes the bug.

@Ma27 Ma27 merged commit 25182e0 into NixOS:master Jun 15, 2021
@Ma27 Ma27 deleted the bump-mautrix-whatsapp branch June 15, 2021 17:40
@github-actions github-actions bot mentioned this pull request Jun 15, 2021
Merged
@github-actions
Copy link
Contributor

Successfully created backport PR #126974 for release-21.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbruder sbruder sbruder approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Vskilet Vskilet Awaiting requested review from Vskilet

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @sbruder