Add option to notify users about channel updates #126987
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
requested changes
Jun 16, 2021
There was a problem hiding this comment.
I think this is missing an entry in https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/module-list.nix
| path = with pkgs; [ coreutils curl gnused ]; | ||
|
|
||
| script = '' | ||
| current=$(cat /nix/var/nix/profiles/system/nixos-version | sed 's/.*\.\([0-9a-f]*\)$/\1/') |
There was a problem hiding this comment.
Also why are we not using bash?
There was a problem hiding this comment.
The file in the nixstore seems to have automatically placed a shebang for bash at the top of the script. Should I explicitly add the shebang and add bash to the path?
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
balsoft
reviewed
Jun 18, 2021
| description = '' | ||
| Whether to notify the user when there are NixOS updates available. | ||
| If enabled, the user service is made available and can be manually | ||
| enabled to activated with a user timer. |
There was a problem hiding this comment.
This sentence doesn't feel right, but I'm not a native English speaker.
Comment on lines
+21
to
+27
| channel = mkOption { | ||
| type = types.str; | ||
| example = "https://nixos.org/channels/nixos-unstable"; | ||
| description = '' | ||
| The URI of the NixOS channel to use for checking updates. | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
Consider also adding a flake option, to check for flake updates.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, updating the system requires manually checking the nixos version, found at
/nix/var/nix/profiles/system/nixos-version, against the channel at /git-revision. This pull request would add an option for a systemd timer which would notify users when their current system version is not the same as the channel.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)