Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.timonwong.shellcheck: 0.12.3 -> 0.14.1 #127046

Merged
merged 1 commit into from Jun 16, 2021

Conversation

happysalada
Copy link
Contributor

@happysalada happysalada commented Jun 16, 2021

Motivation for this change

updates the shellcheck plugin
and add the shellcheck dependency directly to the plugin.
You can verify by jq '.contributes.configuration.properties."shellcheck.executablePath".default' ./result/share/vscode/extensions/timonwong.shellcheck/package.json
the shellcheck path will appear. That way, shellcheck doesn't specifically need to be specified anywhere to be able to use the plugin.

Leaving this one day open in case anybody is interested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants