-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closure-size: nix-serve: include bzip2 on PATH #12771
Conversation
By analyzing the blame information on this pull request, we identified @edolstra and @wkennington to be potential reviewers |
Actually bzip2 should be coming from here: https://github.com/NixOS/nixpkgs/blob/closure-size/nixos/modules/services/networking/nix-serve.nix#L53. Which means we should do the output selection thing in |
@dezgeg Thanks! We'll do that in another PR. Closing this one. |
Well, arguably it's cleaner to fix it in the wrapper script than in the systemd service, since the latter makes it work for all users. |
@edolstra Well, the wrapper script was missing bzip2, so if you weren't using the systemd service, it was already broken. But @dezgeg pointed out (rightly) that all systemd services are having their PATH set improperly; we should be doing |
That seems hacky. Why |
Yes, absolutely. That's what I meant. I may not have quoted the expression correctly. 😃 |
And for clarification: this is what the closure-size branch currently uses for choosing what to install in the user environment: |
No, because that PR was never merged. |
This fixes nix-serve on the closure-size branch.
/cc @vcunat