aws-client-vpn: init at 1.0.0 #128262

mcwitt · 2021-06-26T23:33:47Z

Motivation for this change

Note: This is not yet working. I'm pretty new to contributing to nixpkgs, and this is my first attempt at packaging a binary, so I'd appreciate any advice on the approach. Below is a description of the issues I've worked around so far.

12a3c2d Start with bare-bones derivation from this wiki example using autoPatchelfHook. The results in a broken binary that immediately fails at runtime with Process terminated. Couldn't find a valid ICU package installed on the system.
592643a Switch to manually patching executables and libraries with patchelf, add missing icu and gtk3 libraries to rpath. Now we get a popup saying There was a problem. Please report the issue (with grayed-out "Agree" button).

1139919 Use wrapProgram from wrapGAppsHook to add redirect from /opt/awsvpnclient to $out/awsvpnclient. Now the error popup is gone and we get a normal-looking license agreement popup. But after accepting the application exits with the following printed to the terminal:

(AWS VPN Client:61868): Gtk-CRITICAL **: 16:23:53.708: gtk_tree_model_iter_nth_child: assertion 'n >= 0' failed

(AWS VPN Client:61868): Gtk-CRITICAL **: 16:23:53.708: gtk_list_store_get_path: assertion 'iter->stamp == priv->stamp' failed
fish: Job 1, 'AWS\ VPN\ Client' terminated by signal SIGSEGV (Address boundary error)

Ran with gdb to find the following context on the segfault

Thread 1 ".AWS VPN Client" received signal SIGSEGV, Segmentation fault.
0x00007fff4d6742d6 in findElementWithHash (pH=0x8e4fe0, pKey=0x7fff4d7ae95f "charindex", pHash=0x0)
    at ../core/sqlite3.c:32947
32947	../core/sqlite3.c: No such file or directory.

Things done

Binary fails at startup with "Process terminated. Couldn't find a valid ICU package installed on the system."

nixos-discourse · 2021-06-27T06:47:08Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/43

pkgs/applications/networking/aws-client-vpn/default.nix

SuperSandro2000 · 2021-06-27T15:47:14Z

pkgs/applications/networking/aws-client-vpn/default.nix

+    ln -s "$out/awsvpnclient/AWS VPN Client" "$out/bin/AWS VPN Client"
+    ln -s "$out/awsvpnclient/Service/ACVC.GTK.Service" "$out/bin/ACVC.GTK.Service"


We cannot have $out/awsvpnclient

I wasn't sure what to do here - the package is meant to be installed in /opt and all executables and libraries are under /opt/awsvpnclient in the package. Would it be better to just copy opt to $out/opt? (I think the binaries hardcode the /opt/awsvpnclient path, which is what made the redirects necessary, but it seems like we'd need to preserve the structure).

/opt/awsvpnclient wont work anyway and if we change the path anyway we can also rewrite it to $out/lib etc.

Thanks, I updated to put awsvpnclient under lib/awsvpnclient in 48375ff

pkgs/applications/networking/aws-client-vpn/default.nix

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

mcwitt · 2021-06-27T16:19:55Z

Thanks for the review @SuperSandro2000 !

mcwitt · 2021-06-27T18:10:16Z

I got a little further in debugging the segfault by running in gdb with

cd $(dirname "$(readlink -f "$(command -v "AWS VPN Client")")")/.. && nix run nixpkgs.gdb -c gdb awsvpnclient/".AWS VPN Client-wrapped"
(gdb) run

which results in

Thread 1 ".AWS VPN Client" received signal SIGSEGV, Segmentation fault.
0x00007fff4d6742d6 in findElementWithHash (pH=0x8e4fe0, pKey=0x7fff4d7ae95f "charindex", pHash=0x0)
    at ../core/sqlite3.c:32947
32947	../core/sqlite3.c: No such file or directory.

(gdb) bt
#0  0x00007fff4d6742d6 in findElementWithHash (pH=0x857820, pKey=0x7fff4d7ae95f "charindex", pHash=0x0) at ../core/sqlite3.c:32947
#1  0x00007fff4d67446a in sqlite3HashFind (pH=0x857820, pKey=0x7fff4d7ae95f "charindex") at ../core/sqlite3.c:33006
#2  0x00007fff4d6dc4cc in sqlite3FindFunction (db=0x8575e8, zName=0x7fff4d7ae95f "charindex", nArg=2, enc=1 '\001', createFlag=0 '\000') at ../core/sqlite3.c:115551
#3  0x00007fff4d768969 in RegisterExtensionFunctions (db=0x8575e8) at ../contrib/extension-functions.c:1817
#4  0x00007fff4d769024 in sqlite3_open_interop (filename=0x7fff58223648 "/home/matt/.config/AWSVPNClient/awsvpnclientmetrics.db", vfsName=0x0, flags=6, extFuncs=1,
    ppdb=0x7fffffffa4b8) at interop.c:429
#5  0x00007fff80617316 in ?? ()
#6  0x007f007f007f007f in ?? ()
#7  0x00000000010a0021 in ?? ()
#8  0x00007ffff7583718 in vtable for InlinedCallFrame () from /nix/store/jxvwn64g5n8ipggwhw5yqn5s311dn95m-aws-client-vpn-1.0.0/awsvpnclient/libcoreclr.so
#9  0x00007fffffffb798 in ?? ()
#10 0x00007fff8069d108 in ?? ()
#11 0x00007fff8069d108 in ?? ()
#12 0x00007fffffffa390 in ?? ()
#13 0x00007fff80617316 in ?? ()
#14 0x00007fffffffa430 in ?? ()
#15 0x00007fff58223638 in ?? ()
#16 0x00007fff8069d108 in ?? ()
#17 0x0000000000635f20 in ?? ()
#18 0x00007fffffffa4b8 in ?? ()
#19 0x0000000000000000 in ?? ()

So it looks like the segfault is happening inside sqlite (but I'm thinking this is more likely to be a manifestation of the problem than a root cause?)

ivankovnatsky · 2021-06-29T18:19:32Z

followed your steps, no clue yet.

you probably want to add yourself to maintainers list: https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix

pkgs/applications/networking/aws-client-vpn/default.nix

SuperSandro2000 · 2021-06-29T22:38:26Z

pkgs/applications/networking/aws-client-vpn/default.nix

          "''${gappsWrapperArgs[@]}"
      done
    '';

+  dontStrip = true;


Without this I get

Failed to create CoreCLR, HRESULT: 0x80004005

when trying to run the binary (I found this workaround mentioned here). Admittedly I don't really understand the issue or why this fixes it; would be good to know if there's a better solution.

This seems to happen with all dotnet applications, no idea why.
IMHO just slap a comment to explain setting this, as in https://github.com/NixOS/nixpkgs/pull/114162/files#diff-07dd1ac705a7596aa88012cb4ed0854081fcb79530bfd88b06b5510c7fe0c571R24-R26

Good call, added a note in baef5fe

Co-authored-by: Ivan Kovnatsky <75213+ivankovnatsky@users.noreply.github.com>

mausch · 2021-08-09T14:07:22Z

I don't have any specific advice but have a look at #114162 for reference - it's another dotnet application from AWS, also packaged as deb, so they probably have roughly the same dependencies, probably need similar workarounds, etc.

mcwitt · 2021-08-12T14:12:47Z

@mausch Thanks for the review! I'm on vacation for another week but planning to come back to this when I return. The example dot net derivation you referenced looks useful.

abhibansal530 · 2022-01-11T05:40:16Z

Any update on this? I am also looking for a nixpkg to run AWS VPN client.

mcwitt · 2022-01-12T06:36:57Z

I see that 1.0.3 is now available. I tried upgrading in the hope that whatever issue was causing the segfault would be resolved, but no such luck.

I did manage to simplify the method of getting to the same result as before by following #114162 and using autoPatchelfHook instead of patching manually. At this point I'm not sure what to try next to resolve the segfault issue. Any pointers (hehe) would be really appreciated.

@abhibansal530 have you given this project a try? It's been satisfactory for me in the meantime. Full disclosure, I'm actually not using AWS VPN at work anymore, so getting this working hasn't been a super high priority for me lately. If anyone is up for taking it over, feel free to.

abhibansal530 · 2022-01-16T13:09:14Z

Thanks @mcwitt , for now I was able to use AWS VPN using project mentioned by you.

ymatsiuk · 2022-03-06T17:23:58Z

I've created a flake for the updated wrapper from samm-git/aws-vpn-client#16 -> here

bhoudebert · 2022-10-28T14:54:39Z

I've created a flake for the updated wrapper from samm-git/aws-vpn-client#16 -> here

I used, with a little bump this https://github.com/ymatsiuk/awsvpnclient based on samm-git

It is working, even if I have to copy/paste the link (triggered link browser does result in a dummy page) I get authenticated.

Could we move forward by including this/part of this as nixpkgs?

wusticality · 2023-09-27T04:10:07Z

I've created a flake for the updated wrapper from samm-git/aws-vpn-client#16 -> here

Thank you so much for this, you saved me on NixOS.

mcwitt added 7 commits June 26, 2021 21:01

Initial attempt with autoPatchelfHook

12a3c2d

Binary fails at startup with "Process terminated. Couldn't find a valid ICU package installed on the system."

Link binaries into bin

d4f10d4

Manually patch to add icu path

592643a

Add gtk3

1b5e271

Add wrapGAppsHook, redirect from /opt/awsvpnclient

1139919

Patch all executables, wrap all entry points

e1b01d7

Prepend packaged libraries to rpath

c52a522

mcwitt force-pushed the aws-client-vpn-init branch from ef73c4a to c52a522 Compare June 27, 2021 06:00

mcwitt marked this pull request as draft June 27, 2021 06:00

Simplify

fb6c310

SuperSandro2000 requested changes Jun 27, 2021

View reviewed changes

mcwitt and others added 4 commits June 27, 2021 09:06

Update pkgs/applications/networking/aws-client-vpn/default.nix

a38438e

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

Update pkgs/applications/networking/aws-client-vpn/default.nix

76948a6

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

Update pkgs/applications/networking/aws-client-vpn/default.nix

0eb95f7

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

Update pkgs/applications/networking/aws-client-vpn/default.nix

01c6cea

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

mcwitt added 3 commits June 27, 2021 09:20

Prepend dirname to rpaths

a976b08

Remove unneeded quotes

5a9c2b1

Add libnuma to library path

5a43938

Move awsvpnclient under lib

48375ff

ivankovnatsky reviewed Jun 29, 2021

View reviewed changes

pkgs/applications/networking/aws-client-vpn/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jun 29, 2021

View reviewed changes

Update pkgs/applications/networking/aws-client-vpn/default.nix

d003076

Co-authored-by: Ivan Kovnatsky <75213+ivankovnatsky@users.noreply.github.com>

ivankovnatsky mentioned this pull request Jul 1, 2021

AWS Client VPN for Linux #128022

Open

mcwitt added 2 commits January 11, 2022 17:21

Merge branch 'master' into aws-client-vpn-init

830653f

Upgrade to 1.0.3, simplify

baef5fe

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 12, 2022

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2022

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 28, 2022

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

aws-client-vpn: init at 1.0.0 #128262

aws-client-vpn: init at 1.0.0 #128262

mcwitt commented Jun 26, 2021 •

edited

nixos-discourse commented Jun 27, 2021

SuperSandro2000 Jun 27, 2021

mcwitt Jun 27, 2021 •

edited

SuperSandro2000 Jun 28, 2021

mcwitt Jun 29, 2021 •

edited

mcwitt commented Jun 27, 2021

mcwitt commented Jun 27, 2021 •

edited

ivankovnatsky commented Jun 29, 2021 •

edited

SuperSandro2000 Jun 29, 2021

mcwitt Jun 29, 2021

mausch Aug 9, 2021

mcwitt Jan 12, 2022

mausch commented Aug 9, 2021

mcwitt commented Aug 12, 2021

abhibansal530 commented Jan 11, 2022 •

edited

mcwitt commented Jan 12, 2022 •

edited

abhibansal530 commented Jan 16, 2022

ymatsiuk commented Mar 6, 2022

bhoudebert commented Oct 28, 2022 •

edited

wusticality commented Sep 27, 2023

		ln -s "$out/awsvpnclient/AWS VPN Client" "$out/bin/AWS VPN Client"
		ln -s "$out/awsvpnclient/Service/ACVC.GTK.Service" "$out/bin/ACVC.GTK.Service"

aws-client-vpn: init at 1.0.0 #128262

Are you sure you want to change the base?

aws-client-vpn: init at 1.0.0 #128262

Conversation

mcwitt commented Jun 26, 2021 • edited

Motivation for this change

Things done

nixos-discourse commented Jun 27, 2021

SuperSandro2000 Jun 27, 2021

Choose a reason for hiding this comment

mcwitt Jun 27, 2021 • edited

Choose a reason for hiding this comment

SuperSandro2000 Jun 28, 2021

Choose a reason for hiding this comment

mcwitt Jun 29, 2021 • edited

Choose a reason for hiding this comment

mcwitt commented Jun 27, 2021

mcwitt commented Jun 27, 2021 • edited

ivankovnatsky commented Jun 29, 2021 • edited

SuperSandro2000 Jun 29, 2021

Choose a reason for hiding this comment

mcwitt Jun 29, 2021

Choose a reason for hiding this comment

mausch Aug 9, 2021

Choose a reason for hiding this comment

mcwitt Jan 12, 2022

Choose a reason for hiding this comment

mausch commented Aug 9, 2021

mcwitt commented Aug 12, 2021

abhibansal530 commented Jan 11, 2022 • edited

mcwitt commented Jan 12, 2022 • edited

abhibansal530 commented Jan 16, 2022

ymatsiuk commented Mar 6, 2022

bhoudebert commented Oct 28, 2022 • edited

wusticality commented Sep 27, 2023

mcwitt commented Jun 26, 2021 •

edited

mcwitt Jun 27, 2021 •

edited

mcwitt Jun 29, 2021 •

edited

mcwitt commented Jun 27, 2021 •

edited

ivankovnatsky commented Jun 29, 2021 •

edited

abhibansal530 commented Jan 11, 2022 •

edited

mcwitt commented Jan 12, 2022 •

edited

bhoudebert commented Oct 28, 2022 •

edited