Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a service which generates Diffie-Hellman parameters for daemons that need them. Parameters are stored in
/var/lib/dhparams
by default. I've added some documentation describing their purpose and example settings for nginx (analogous to our acme module).I've found out about #11505 post-factum. The main difference between our solutions is that I don't store generated parameters in the Nix store, avoiding non-determinism. Personally I like that solution more (a thought of purposely non-deterministic Nix outputs contradicts my views on Nix ~_^), but I understand some advantages of doing it as an output and am open for discussion.
cc @fpletz