Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhparams service: init #12912

Closed
wants to merge 1 commit into from
Closed

dhparams service: init #12912

wants to merge 1 commit into from

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Feb 9, 2016

This adds a service which generates Diffie-Hellman parameters for daemons that need them. Parameters are stored in /var/lib/dhparams by default. I've added some documentation describing their purpose and example settings for nginx (analogous to our acme module).

I've found out about #11505 post-factum. The main difference between our solutions is that I don't store generated parameters in the Nix store, avoiding non-determinism. Personally I like that solution more (a thought of purposely non-deterministic Nix outputs contradicts my views on Nix ~_^), but I understand some advantages of doing it as an output and am open for discussion.

cc @fpletz

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @edolstra, @nbp and @bjornfor to be potential reviewers

@globin
Copy link
Member

globin commented Feb 10, 2016

See this, too mayflower@f55e544

@edolstra
Copy link
Member

I'm not so sure about this. This seems like a pretty large wrapper around what is essentially just a one-line call to openssl dhparam. If nginx needs DH parameters, wouldn't it be better to do that in the nginx preStart script? It also seems strange to specify nginx configuration outside of services.nginx.

@abbradar
Copy link
Member Author

I thought about that too, but it seemed to me that it would be too much boilerplate copied between different services. Some I know of that need DH parameters are Postfix, ejabberd, nginx and OpenVPN -- I also have a real-world configuration that needs four different generated parameters for different services.

EDIT: On the other hand, each service requires different configuration options that can be set by respective services automatically if we take "copy-for-each-service" route...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants