Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

juju: init at 2.8.7 #129279

Merged
merged 2 commits into from
Jul 5, 2021
Merged

juju: init at 2.8.7 #129279

merged 2 commits into from
Jul 5, 2021

Conversation

RealityAnomaly
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit July 4, 2021 22:34
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/554

SuperSandro2000
SuperSandro2000 requested changes Jul 5, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format according to the contributing guide. Using nixpkgs-fmt can help a lot with this.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/networking/juju/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/juju/default.nix Outdated Show resolved Hide resolved
@RealityAnomaly RealityAnomaly force-pushed the init/juju branch 3 times, most recently from 1935a24 to 0a68f0f Compare July 5, 2021 16:03
SuperSandro2000
SuperSandro2000 requested changes Jul 5, 2021
View reviewed changes
pkgs/applications/networking/juju/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/juju/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/juju/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit 22ead69 into NixOS:master Jul 5, 2021
@RealityAnomaly RealityAnomaly deleted the init/juju branch July 5, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RealityAnomaly @nixos-discourse @SuperSandro2000 @Janik-Haag