Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lua 5.1 (again) with neovim on aarch64 #129543

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Use lua 5.1 (again) with neovim on aarch64 #129543

merged 1 commit into from
Jul 8, 2021

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Closes #129099

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@rvolosatovs
Revert "neovim: remove lua override"
fadf584 
This reverts commit 68a780e.

Also, add some context
This was referenced Jul 7, 2021
Closed
Closed
@rvolosatovs
Copy link
Member Author

For testing:

nix run -f 'https://github.com/rvolosatovs/nixpkgs/archive/fix/neovim-lua-aarch64.tar.gz' neovim -c nvim

@rvolosatovs
Copy link
Member Author

rvolosatovs commented Jul 7, 2021 •
edited
Loading

cc @manveru @Ma27 (maintainers)
cc @thiagokokada #110837 (comment)
cc @gebner #110837 (comment) I think the build my m1 was using was actually for x86_64 - on a new installation build failed, although with different error than in the issue it seems 🤔

@rvolosatovs rvolosatovs requested review from manveru and Ma27 July 7, 2021 18:14
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 129543 at fadf584 run on aarch64-linux 1

6 packages built successfully:
  • gnvim
  • neovim-qt
  • neovim-qt-unwrapped
  • neovim-remote
  • neovim-unwrapped
  • nvimpager

@Mic92 Mic92 merged commit 5468e83 into NixOS:master Jul 8, 2021
@rvolosatovs rvolosatovs deleted the fix/neovim-lua-aarch64 branch July 8, 2021 13:54
@lovesegfault
Copy link
Member

I am confused, this diff seems to do the exact opposite of what the PR states it does?

@rvolosatovs rvolosatovs changed the title Use luajit (again) with neovim on aarch64 Use lua 5.1 (again) with neovim on aarch64 Jul 14, 2021
@rvolosatovs
Copy link
Member Author

I am confused, this diff seems to do the exact opposite of what the PR states it does?

You're right, my bad! Changed the title.

@bnjmnt4n bnjmnt4n mentioned this pull request Aug 7, 2021
Merged
11 tasks
teto pushed a commit that referenced this pull request Aug 7, 2021
@bnjmnt4n @teto
neovim: build with luajit on aarch64-linux
a537bad 
#129543 disabled building neovim
with luajit on all `aarch64` platforms, however, building neovim with
luajit on `aarch64-linux` builds successfully, and avoids various issues
I encountered with some Lua-based plugins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issues with neovim 0.5.0 on an M1 macbook
4 participants
@rvolosatovs @r-rmcgibbo @lovesegfault @Mic92