Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ode: 0.12 -> 0.16.2 #130644

Merged
merged 2 commits into from
Jul 20, 2021
Merged

ode: 0.12 -> 0.16.2 #130644

merged 2 commits into from
Jul 20, 2021

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates ODE to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jul 19, 2021

Result of nixpkgs-review pr 130644 at 0ea33355 run on x86_64-linux 1

2 packages failed to build:
1 package skipped due to time constraints:
  • freecad
1 package built successfully:
  • ode
3 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/ode/default.nix:12:3:

       |
    12 |   meta = with lib; {
       |   ^
    
  • warning: unclear-gpl

    lgpl21 is a deprecated license, please check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

    Near pkgs/development/libraries/ode/default.nix:16:5:

       |
    16 |     license = with licenses; [ bsd3 lgpl21 lgpl3 zlib ];
       |     ^
    
  • warning: unclear-gpl

    lgpl3 is a deprecated license, please check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

    Near pkgs/development/libraries/ode/default.nix:16:5:

       |
    16 |     license = with licenses; [ bsd3 lgpl21 lgpl3 zlib ];
       |     ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 130644 at 0ea33355 run on aarch64-linux 1

1 package failed to build:
1 package skipped due to time constraints:
  • freecad
1 package built successfully:
  • ode
3 suggestions:
  • warning: unclear-gpl

    lgpl21 is a deprecated license, please check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

    Near pkgs/development/libraries/ode/default.nix:16:5:

       |
    16 |     license = with licenses; [ bsd3 lgpl21 lgpl3 zlib ];
       |     ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/ode/default.nix:12:3:

       |
    12 |   meta = with lib; {
       |   ^
    
  • warning: unclear-gpl

    lgpl3 is a deprecated license, please check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

    Near pkgs/development/libraries/ode/default.nix:16:5:

       |
    16 |     license = with licenses; [ bsd3 lgpl21 lgpl3 zlib ];
       |     ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@lopsided98
Copy link
Contributor Author

freecad builds successfully and fluxus was already broken.

xmoto was broken by the PR, and the easiest way to fix that is to upgrade it to the latest version. I based on the updated expression on the one now included in the upstream repository: https://github.com/xmoto/xmoto/blob/master/nix/xmoto.nix. I did not include any of the feature flags, since they are discouraged in nixpkgs.

};

meta = with lib; {
description = "Open Dynamics Engine";
homepage = "https://sourceforge.net/projects/opende";
homepage = "https://www.ode.org";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the SF project page links to the new website.

@7c6f434c 7c6f434c merged commit a1f18b0 into NixOS:master Jul 20, 2021
@lopsided98 lopsided98 deleted the ompl-update branch July 20, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants