Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "llvm_12: disable failing 'DebugInfo/X86/vla-multi.ll' on armv7l" #131078

Merged
merged 1 commit into from Aug 2, 2021

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jul 22, 2021

This reverts commit 68bc5b4.

Motivation for this change

9a761a4 removes 'DebugInfo/X86/vla-multi.ll' on all platforms.

This should fix build on armv7l: https://hydra.cons.org.nz/build/16554/nixlog/1/tail.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This reverts commit 68bc5b4.

9a761a4 removes 'DebugInfo/X86/vla-multi.ll' on all platforms.
@misuzu
Copy link
Contributor Author

misuzu commented Jul 23, 2021

It builds with this change.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/572

@SuperSandro2000 SuperSandro2000 merged commit 513e78a into NixOS:master Aug 2, 2021
@misuzu misuzu deleted the llvm12_armv7l_revert branch June 7, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants