Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.deemix: init at 3.4.1 #132580

Merged
merged 2 commits into from Aug 5, 2021
Merged

Conversation

natto1784
Copy link
Contributor

Motivation for this change

Wanted to use/package this simple tool to download music from deezer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Comment on lines 10 to 13
}:
buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}:
buildPythonPackage rec {
}:
buildPythonPackage rec {


meta = with lib; {
homepage = "https://git.freezer.life/RemixDev/deemix-py";
description = "deemix is a deezer downloader built from the ashes of Deezloader Remix.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "deemix is a deezer downloader built from the ashes of Deezloader Remix.";
description = "Deezer downloader built from the ashes of Deezloader Remix";

see https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md

@natto1784 natto1784 force-pushed the deemix branch 2 times, most recently from 7dcdf40 to c2de598 Compare August 3, 2021 20:25
@natto1784 natto1784 requested a review from fabaff August 3, 2021 20:38
@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 3, 2021

Result of nixpkgs-review pr 132580 at c2de5980 run on x86_64-linux 1

4 packages built successfully:
  • python38Packages.deemix
  • python38Packages.deezer-py
  • python39Packages.deemix
  • python39Packages.deezer-py
2 suggestions:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/deezer-py/default.nix:25:0:

       |
    25 |     description = "A wrapper for all Deezer's APIs";
       | ^
    
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/deemix/default.nix:37:0:

       |
    37 |     description = "Deezer downloader built from the ashes of Deezloader Remix";
       | ^
    

Result of nixpkgs-review pr 132580 at c2de5980 run on aarch64-linux 1

4 packages built successfully:
  • python38Packages.deemix
  • python38Packages.deezer-py
  • python39Packages.deemix
  • python39Packages.deezer-py
2 suggestions:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/deemix/default.nix:37:0:

       |
    37 |     description = "Deezer downloader built from the ashes of Deezloader Remix";
       | ^
    
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/deezer-py/default.nix:25:0:

       |
    25 |     description = "A wrapper for all Deezer's APIs";
       | ^
    

@risicle
Copy link
Contributor

risicle commented Aug 4, 2021

I've actually been looking at getting a spleeter package working but have been delayed by our tensorflow being a little broken until recently. Should dust that off...

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 132580 run on x86_64-linux 1

4 packages built:
  • python38Packages.deemix
  • python38Packages.deezer-py
  • python39Packages.deemix
  • python39Packages.deezer-py

@SuperSandro2000 SuperSandro2000 merged commit 000df55 into NixOS:master Aug 5, 2021
@fabaff fabaff mentioned this pull request Aug 19, 2021
10 tasks
@natto1784 natto1784 deleted the deemix branch September 20, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants