Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex: allow use on non-x86 platforms #132963

Merged
merged 2 commits into from Aug 17, 2022
Merged

plex: allow use on non-x86 platforms #132963

merged 2 commits into from Aug 17, 2022

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 7, 2021 •
edited

Motivation for this change

The use of glibc_multi within buildFHSUserEnvBubblewrap was preventing the usage of FHSUserEnv application from being used outside of x86.

Also, fix plex on aarch64-linux

[03:21:55] jon@nixos-raspberrypi ~/projects/nixpkgs (plex-on-aarch64)
$ nix-build -A plex
/nix/store/7liwn2gbkwf0wyspxb0dy1xxrv8hvzsf-plexmediaserver
[03:23:30] jon@nixos-raspberrypi ~/projects/nixpkgs (plex-on-aarch64)
$ uname -a
Linux nixos-raspberrypi 4.19.118 #1-NixOS SMP Tue Jan 1 00:00:00 UTC 1980 aarch64 GNU/Linux
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/plex-on-aarch64/13945/4

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/using-a-multilib-gcc-within-an-fhs-environment/14560/7

@wegank wegank mentioned this pull request Jan 24, 2022
Closed
@stale
Copy link

stale bot commented Apr 18, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 18, 2022
@yusefnapora
Copy link

Just registering interest in this, since I've been trying to use appimageTools to wrap WebCatalog for aarch64, and it's giving a similar build error (''i686 Linux package set can only be used with the x86 family.").

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 15, 2022
@jonringer
Copy link
Contributor Author

updated PR

@bachp bachp merged commit 6af1c99 into NixOS:master Aug 17, 2022
@K900
Copy link
Contributor

K900 commented Aug 17, 2022

This broke eval. Fix in #187161

@bachp bachp mentioned this pull request Aug 18, 2022
Merged
13 tasks
@ohlus ohlus mentioned this pull request Aug 22, 2022
Closed
@jonringer jonringer deleted the plex-on-aarch64 branch December 17, 2022 18:01
winterqt
winterqt reviewed Apr 26, 2023
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -9444,7 +9444,9 @@ with pkgs;
inherit (callPackage ../servers/plik { })
plik plikd;

plex = callPackage ../servers/plex { };
plex = callPackage ../servers/plex {
buildFHSUserEnv = buildFHSUserEnvBubblewrap;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonringer Do you remember why you did this, instead of just updating the reference in the Plex package itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Artturin Artturin Artturin left review comments

@winterqt winterqt winterqt left review comments

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jonringer @nixos-discourse @yusefnapora @K900 @SuperSandro2000 @Artturin @winterqt @bachp