nixos/test-driver: minor fixes for nixos-build-vms(8)
#133675
Conversation
Originally removed in 926fb93. This one is actually quite useful for `nixos-build-vms(8)`.
This is relevant for `nixos-build-vms(8)` which doesn't have a test-script. In that case it's more intuitive to directly go into the interactive mode which is IMHO more intuitive.
| @@ -1061,7 +1062,8 @@ def clean_up() -> None: | |||
| process.terminate() | |||
| log.close() | |||
|
|
|||
| interactive = args.interactive or (not bool(testscript)) | |||
|
Looks great, let's run some tests to be sure: @GrahamcOfBorg test bittorrent |
This is the case when the test-script is empty. `nixos-build-vms(8)` is primarily supposed to be used as tool to test changes or to reproduce bugs (IMHO) where "just spinning up a few VMs" is the primary use-case. In the ongoing discussion about these changes[1] it was suggested to only expose it when needed (i.e. in the case I described above) to keep the API surface as slim as possible. [1] NixOS#133675 (comment)
|
cc @tfc anything to add? :) |
Motivation for this change
Follow-up for #125979. While I agree with the overall approach from said PR, I don't really like the current implications for
nixos-build-vms(8). This PR aims to fix that.Further details for the actual changes can be found in the commit-messages.
cc @blaggacao
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)