Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsStatic.perl: Use dontAddStaticConfigureFlags instead of overriding #133851

Merged
merged 1 commit into from
Aug 16, 2021
Merged

pkgsStatic.perl: Use dontAddStaticConfigureFlags instead of overriding #133851

merged 1 commit into from
Aug 16, 2021

Conversation

Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Aug 14, 2021 •
edited
Loading

Motivation for this change

With the current override pkgsStatic.perl doesn't build when using a different stdenv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Pamplemousse
pkgsStatic.perl: Use dontAddStaticConfigureFlags instead of overriding
1dbb306 
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@ofborg ofborg bot requested a review from edolstra August 14, 2021 02:20
@Pamplemousse Pamplemousse marked this pull request as ready for review August 16, 2021 19:26
@Pamplemousse
Copy link
Member Author

cc @alyssais @Ericson2314

@Ericson2314 Ericson2314 merged commit b02a724 into NixOS:staging Aug 16, 2021
@alyssais
Copy link
Member

This has broken the build of pkgsStatic.perl for me, even on the head of this PR. Did it work for you?

alyssais added a commit to alyssais/nixpkgs that referenced this pull request Sep 15, 2021
@alyssais
strace: remove strace-graph stuff
ea1775e 
strace-graph is no longer installed as of strace v5.11[1].  The perl
build input was only needed for the patchShebangs line, but was
causing pkgsStatic.strace to fail to build since pkgsStatic.perl is
currently broken[2].

[1]: strace/strace@5685c0d
[2]: NixOS#133851 (comment)
@alyssais alyssais mentioned this pull request Sep 15, 2021
Merged
12 tasks
@Pamplemousse
Copy link
Member Author

AFAIR, it did...
I haven't used any of the pkgsStatic stuff in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@stigtsp stigtsp Awaiting requested review from stigtsp stigtsp is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pamplemousse @alyssais @Ericson2314