Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erigon 2021-08-04 #135524

Merged
merged 3 commits into from Aug 26, 2021
Merged

Erigon 2021-08-04 #135524

merged 3 commits into from Aug 26, 2021

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented Aug 24, 2021

Motivation for this change

new version (including a critical security fix): https://github.com/ledgerwatch/erigon/releases/tag/v2021.08.04

Supersedes #135135.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 24, 2021

Result of nixpkgs-review pr 135524 at 2952fd01 run on aarch64-linux 1

1 package failed to build:
1 package built successfully:
  • nixos-install-tools
1 suggestion:
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/applications/blockchains/erigon.nix:1:3:

      |
    1 | { stdenv, lib, buildGoModule, fetchFromGitHub }:
      |   ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 135524 at f1dea7e run on x86_64-linux 1

2 packages built successfully:
  • erigon
  • nixos-install-tools

@d-xo
Copy link
Contributor Author

d-xo commented Aug 24, 2021

fixed failing build and removed unused stdenv arg

@d-xo
Copy link
Contributor Author

d-xo commented Aug 25, 2021

This version contains a critical security fix, it would be great to get it merged asap

@d-xo
Copy link
Contributor Author

d-xo commented Aug 26, 2021

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/579

@SuperSandro2000 SuperSandro2000 merged commit 1fc2520 into NixOS:master Aug 26, 2021
@d-xo d-xo deleted the erigon-2021-08-04 branch August 26, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants