Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This needs to be backported, because it contains a fix for Thinkpad users using Linux 5.13 on NixOS 21.05.
Thinkpads pull in the
acpi_call
out-of-tree module for power management via nixos-hardware. The 1.2.1 version ofacpi_call
is unfortunately incompatible to Linux 5.13 and will cause a null pointer dereference in the kernel.This was fixed in
acpi_call
1.2.2.I'm running the update
acpi_call
module on the Thinkpad I'm writing this on.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)