Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canta-theme: 2021-07-06 -> 2021-09-08 #137097

Merged
merged 1 commit into from Sep 11, 2021
Merged

canta-theme: 2021-07-06 -> 2021-09-08 #137097

merged 1 commit into from Sep 11, 2021

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 8, 2021

Motivation for this change

Update to version 2021-09-08

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 8, 2021

Result of nixpkgs-review pr 137097 at 21ddf57 run on x86_64-linux 1

1 package built successfully:
  • canta-theme
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/data/themes/canta/default.nix:47:3:

       |
    47 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 137097 at 21ddf57 run on aarch64-linux 1

1 package built successfully:
  • canta-theme

@SuperSandro2000 SuperSandro2000 merged commit 99031a4 into NixOS:master Sep 11, 2021
@romildo romildo deleted the upd.canta-theme branch September 12, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants