Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/qemu-vm: use native qemu when cross-compiling #138774

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

nixos/qemu-vm: use native qemu when cross-compiling #138774

wants to merge 1 commit into from

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Sep 21, 2021

I think this is a more sensible default for the qemu package.
If you're cross-compiling a NixOS VM, you're more likely to want
to run the VM on the build machine than the host machine.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from alyssais September 21, 2021 12:04
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@r-burns
nixos/qemu-vm: use native qemu when cross-compiling
e80cd60 
I think this is a more sensible default for the qemu package.
If you're cross-compiling a NixOS VM, you're more likely to want
to run the VM on the build machine than the host machine.
@r-burns
Copy link
Contributor Author

r-burns commented Oct 16, 2022

Rebased to fix merge conflict

@r-burns r-burns removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 16, 2022
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank marked this pull request as draft March 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ck3d ck3d ck3d approved these changes

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
QEMU VM tests refactors
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-burns @ck3d @alyssais @SuperSandro2000 @wegank